Fix icon in index.yaml #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonah Kowall <[email protected]>
yurishkuro
reviewed
Apr 23, 2024
index.yaml
Outdated
| @@ -23,11 +23,12 @@ entries: | |||
| description: A Jaeger Helm chart for Kubernetes | |||
| digest: 948a87dd5cb4ac4095a5b0e2c817ccbb193709b49668104993b5642398c7e27b | |||
| home: https://jaegertracing.io | |||
| icon: https://camo.githubusercontent.com/afa87494e0753b4b1f5719a2f35aa5263859dffb/687474703a2f2f6a61656765722e72656164746865646f63732e696f2f656e2f6c61746573742f696d616765732f6a61656765722d766563746f722e737667 | |||
| icon: https://artifacthub.io/image/bffa8705-c91a-48d5-92fc-8054d9478d77@2x | |||
There was a problem hiding this comment.
I don't know the origin of that icon on the hub. It's better to refer to official logo here https://github.com/cncf/artwork/tree/main/projects/jaeger
e.g. https://raw.githubusercontent.com/cncf/artwork/main/projects/jaeger/icon/color/jaeger-icon-color.png
There was a problem hiding this comment.
I uploaded that one to artifacthub, but I will ref this one instead.
There was a problem hiding this comment.
Should be good now.
Signed-off-by: Jonah Kowall <[email protected]>
yurishkuro
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes the icon which is currently showing an error in Artifact Hub
This might help us get the official badge, if not I have to ask that team for help.
Which issue this PR fixes
jaegertracing/jaeger#5363
Checklist
[jaeger]or[jaeger-operator])