Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong position when using Icons #8

Closed
dNadiia opened this issue Nov 11, 2017 · 5 comments · May be fixed by #10
Closed

Wrong position when using Icons #8

dNadiia opened this issue Nov 11, 2017 · 5 comments · May be fixed by #10

Comments

@dNadiia
Copy link

dNadiia commented Nov 11, 2017

ActionSheet has 3 items, every with icon in size 42, position: doesn't matter, problem is in both.
Initial position is wrong, first (for top position is last) item is visible:
start_position
If 'Show' appearing works correctly:
end_position
If 'Hide' after that position will be right. Problem only with initial position.
@dNadiia
Copy link
Author

dNadiia commented Nov 13, 2017

How to fix that?

@dNadiia dNadiia mentioned this issue Nov 13, 2017
Open
@LucasMonteiro1
Copy link

I have the same problem, please merge PR opened

@jacklam718
Copy link
Owner

@LucasMonteiro1 @dNadiia Sorry, I forgot have pending pull requests here. I will review and test ASAP.

@jacklam718
Copy link
Owner

@dNadiia Thanks for your PR.

@jacklam718
Copy link
Owner

Fixed in version v0.0.35 @LucasMonteiro1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed initial position Lukatu/react-native-action-sheet-component
3 participants
@jacklam718 @dNadiia @LucasMonteiro1