General feedback

[jumarko]

Once again, thanks for the great course and lots of new videos recently!

I want to mention a couple of "problems" I've had with the setup and the presentation method:

Dev workflow

As I said before, I found the development workflow problematic - the handler functions seem to be captured somehow and an updated definition is not available without server restart although I reference handlers as vars (via #')

We discussed this earlier and I heard that there will ultimately be a better workflow but I think it would be better to introduce this earlier, perhaps as an extra lesson after the last one in the Component series (Component REPL)

Wanted: Smaller steps

You often write way too much code, for my taste, in one go

Example: in lesson 26 Retrieve recipe, you wrote the whole retrieve-recipe-response thing without testing it. You even mentioned it briefly at the end that you think it's fine to go without testing incrementally. I don't think so.

I'd much prefer to take smaller steps, especially since this is all about learning.
So I'd perhaps wrote this first: jumarko/learn-pedestal@4fd4d61

(defn retrieve-recipe-response
[{:keys [path-params system/database] :as request}]
(let [db (:db database)
recipe-id (parse-uuid (:recipe-id path-params))]
(response/response (str recipe-id))))

Then test it:

  (pt/response-for (-> cr/system :api-server :service ::http/service-fn)
                   :get recipe-url
                   :headers {"Authorization"  "auth|5fbf7db6271d5e0076903601"})
;; => {:status 200, :body "7e485d7a-23c1-4519-8043-15dbb38775b7", ...

Then I'd implement the query part: jumarko/learn-pedestal@51c533a

(defn- retrieve-recipe [db recipe-id]
  (let [recipe (d/q '[:find (pull ?e pattern)
                      :in $ ?recipe-id pattern
                      :where [?e :recipe/recipe-id ?recipe-id]]
                    db recipe-id recipe-pattern)]
    recipe))

(defn retrieve-recipe-response
  ;; Notice `path-params`
  [{:keys [path-params system/database] :as _request}]
  (let [db (:db database)
        recipe-id (parse-uuid (:recipe-id path-params))]
    (response/response (retrieve-recipe db recipe-id))))

Again, these are little annoyances - the course is great anyway and thank you again for all the hard work.

[jacekschae]

Thanks so much for your comments. I should have done a better job explaining why I went this route -- skipping tests and repl -- it's much better explained toward the end of video 31 - Retract recipe. There is a lot going on in the Recipes videos and I focus only on the flow with interceptors without testing and repl.

I'll take your pointes into the account going forward and will try to do a better job with this. I hope you will have a chance to watch video 31 and let me know what you think about it.

[jumarko]

I'll definitely watch it.
Thanks for the reply!