Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedback from angular folks #15

Open
iynere opened this issue Jan 28, 2019 · 1 comment
Open

feedback from angular folks #15

iynere opened this issue Jan 28, 2019 · 1 comment

Comments

@iynere
Copy link
Owner

iynere commented Jan 28, 2019

angular/angular@7374dfd

@iynere
Copy link
Owner Author

iynere commented Jan 28, 2019

  1. (By looking at the code) it would only work if the rerun workflow is the latest workflow on the branch (which is not guaranteed to be true)
  2. It is less efficient (e.g. makes unnecessary CircleCI API requests for builds on different branches, installs extra dependencies, persists files to the workspace (as a means of passing the result to the calling job), etc.)
  3. It is slightly more complicated to setup and consume than our own script
  4. Its implementation is more complicated than needed for our usecase (e.g. handles different git providers, handles newly created branches, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant