Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "v" in "v1.2.3" optional #376

Open
d-miketa opened this issue Jul 12, 2023 · 2 comments
Open

Make "v" in "v1.2.3" optional #376

d-miketa opened this issue Jul 12, 2023 · 2 comments
Labels
design Design questions, that affects the product significantly discussion Discussion is needed to reach conclusion

Comments

@d-miketa
Copy link

Hi,

Would it be possible to make the "v" in "v1.2.3" optional? It's not strict semver. https://semver.org/#is-v123-a-semantic-version

Thanks! :)

@d-miketa d-miketa added the epic Epic level issue (>2 weeks) label Jul 12, 2023
@aguschin
Copy link
Contributor

Hi @d-miketa! We discussed this a while ago, and decided to keep v #127 (comment)

It makes sense to keep GTO tags in a single format (not supporting it with v and without) both for simplicity of what you can expect to see and different corner cases that may arise, so I wonder, is it just something that doesn't look right (since it's not vanilla semver) or it block some scenarios for you?

@aguschin aguschin added the discussion Discussion is needed to reach conclusion label Jul 13, 2023
@d-miketa
Copy link
Author

Hi @aguschin :)

Thanks for that link, I'll give it a careful read. In the meantime, I can explain where I'm coming from.

I'm not aware of any strict incompatibility with another tool. My request is motivated purely by trying to put together a nice UX that's as consistent as possible - and our Python packages are indexed with regular semver. So it's less that it doesn't look right (an aesthetic concern) and more that I'll have to explain to other users, who don't know gto, that there is a special convention they have to follow for exactly one step in a multi-step process. This creates friction and opportunities for user errors. I'd rather get ahead of the support tickets and use consistent versioning across all steps.

@aguschin aguschin added design Design questions, that affects the product significantly and removed epic Epic level issue (>2 weeks) labels Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design questions, that affects the product significantly discussion Discussion is needed to reach conclusion
Projects
None yet
Development

No branches or pull requests

2 participants