Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve the overlapping text in interoperability page with an elegant solution #1415

Open
bfabio opened this issue Aug 30, 2023 · 9 comments · Fixed by italia/next.developers.italia.it#15

Comments

@bfabio
Copy link
Member

bfabio commented Aug 30, 2023

This is the render of https://next.developers.italia.it/it/interoperabilita/ on my system at 1128x635 pixels:

image

The text in the first column overlaps.

@MMMJB
Copy link

MMMJB commented Aug 31, 2023

The static heights for .content-section defined here allows the content to overlap. Either take the naive approach and increase the heights in the media queries or set it to something like max-content with the tradeoff of getting rid of the nice column text alignment.

@bfabio
Copy link
Member Author

bfabio commented Sep 20, 2023

@MMMJB do you think there's a way to have the best of both worlds?

@MMMJB
Copy link

MMMJB commented Sep 23, 2023

You could probably make it work with viewport units. I'd recommend playing around with vh values and then clamping them between a min and a max.

@HeetVekariya
Copy link

  • Hey we can do solve this by just adding a 35px margin above all the "Strumenti correlati".

  • You can see in the screenshot.
    image

  • If this is issue is still open and my solution finds you well, can you please assign it to me ?

@Shashankpantiitbhilai
Copy link

I will handle it ,please assign it to me

@bfabio
Copy link
Member Author

bfabio commented Oct 26, 2023

Thanks @Shashankpantiitbhilai, note that the source for that page is actually in this repo: https://github.com/italia/next.developers.italia.it

@HeetVekariya
Copy link

@bfabio is my solution correct ?

@bfabio
Copy link
Member Author

bfabio commented Oct 27, 2023

@HeetVekariya whoops, sorry, I missed your proposal. I don't think it's the right one, because it uses a magic number of pixels that won't adapt with the content, but fix just the symptom.

@smonolo
Copy link
Contributor

smonolo commented Mar 24, 2024

@bfabio I pushed a fix that temporarily solves the issue, although I don't like the solution that much.

@bfabio bfabio reopened this Mar 25, 2024
@bfabio bfabio changed the title Overlapping text in interoperability page Solve the overlapping text in interoperability page with an elegant solution Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants