Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we merge bookinfo-versions info bookinfo? #50871

Open
2 tasks done
linsun opened this issue May 6, 2024 · 4 comments
Open
2 tasks done

Can we merge bookinfo-versions info bookinfo? #50871

linsun opened this issue May 6, 2024 · 4 comments

Comments

@linsun
Copy link
Member

linsun commented May 6, 2024

Is this the right place to submit this?

  • This is not a security vulnerability or a crashing bug
  • This is not a question about how to use Istio

Bug Description

It is a little cumbersome to have 2 yamls for 1 bookinfo app. Seems no harm to merge even for classic Istio resources or Gateway API?

@frankbu any objection?

Examples where this would be useful:

https://preliminary.istio.io/latest/docs/ambient/getting-started/
and https://deploy-preview-15007--preliminary-istio.netlify.app/latest/docs/ambient/usage/waypoint/#attach-a-l7-policy-to-a-specific-service

Version

istio 1.22 dev

Additional Information

No response

@frankbu
Copy link
Contributor

frankbu commented May 6, 2024

Although nothing will break, it might make things confusing for users of the Istio classic API since they are not used. The version Services are only used with Gateway API, classic API uses DestinationRule subsets to define the versions.

@linsun
Copy link
Member Author

linsun commented May 6, 2024

Understood @frankbu, can we create a v2 of bookinfo in samples/bookinfo/platform/kube/bookinfo-v2.yaml for ambient? any other ideas? :)

@frankbu
Copy link
Contributor

frankbu commented May 6, 2024

bookinfo-v2.yaml would also be confusing since we have other files like bookinfo-details-v2.yaml where v2 means something completely different 😄

Maybe something like bookinfo-all.yaml for use in the ambient docs?

@linsun
Copy link
Member Author

linsun commented May 6, 2024

Ah :) didn't realize v2 could be confusing too! bookinfo-all.yaml SGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants