Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Glob 10. #53

Open
brotkel opened this issue Jan 3, 2024 · 0 comments · May be fixed by #54
Open

Support Glob 10. #53

brotkel opened this issue Jan 3, 2024 · 0 comments · May be fixed by #54

Comments

@brotkel
Copy link

brotkel commented Jan 3, 2024

Hello,
text-exclude currently requires Glob 7, which includes Inflight, which has a security issue: CWE-772. Inflight will not be fixed and the developer encourages everyone to upgrade to Glob 9 or 10, which don't have the dependency. Currently, overriding Glob to use 10 causes test-exclude to throw an error when used in Jest.

TypeError: The "original" argument must be of type function. Received an instance of Object

      at Object.<anonymous> (node_modules/test-exclude/index.js:5:14)
      at Object.<anonymous> (node_modules/babel-plugin-istanbul/lib/index.js:18:43)

This would cause tests in Jest to break if developers try to mitigate the security bulletin.
Using Glob 9 currently works, but then other packages break, so it would be great if test-exclude could use the latest.

@w3nl w3nl linked a pull request Jan 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant