bump node version to 16 #741
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be fine to do, but I'm not sure if a breaking change just to bump the node version is needed (unless it also allows us to e.g. update some dependencies or some such) |
|
@jimmywarting bother you to update this to Node 18, now that 16 is EOL? @SimenB given we're jumping so many version #s as a minimum engine #, I think this should be a breaking change (upstream users can choose not to bump their major). |
|
yeah, definitely a breaking change regardless of which versions are dropped. My question was more - what does it give us to drop old versions? Dropping them "just because" doesn't seem valuable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update raises the minimum required Node.js version to v16. This change enables us to embrace newer technologies without hesitation and eliminates the need to consider whether it's acceptable to utilize modern solutions or resort to older code styles. This enhancement not only improves the overall development experience but also encourages contributions if they can contribute with newer modern code.
fix #739