Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document how and when subprocesses send coverage to nyc & that coverage will be lost for SIGKILLed processes #145

Open
jedwards1211 opened this issue Oct 28, 2016 · 2 comments

Comments

@jedwards1211
Copy link

It seems obvious in retrospect, but I spent hours trying to figure out why I wasn't getting coverage for certain files until I realized it was because I was killing subprocesses that ran those files with SIGKILL. Documentation of this in the README would help others with the same situation figure out why quickly, and I'd be happy to make a PR.

It would be nice to get a high-level overview before digging through the code though. Do subprocesses send coverage to nyc in a process.on('exit', ...) hook, or where? And do they send it via IPC, some kind of sockets, or some other mechanism? If its a coverage channel that can possibly get blocked it would be helpful to document so that people can troubleshoot why files aren't getting covered.

@jedwards1211 jedwards1211 changed the title document how and when subprocesses send coverage to nyc & that coverage will be lost for killed processes document how and when subprocesses send coverage to nyc & that coverage will be lost for SIGKILLed processes Oct 28, 2016
@bcoe
Copy link
Member

bcoe commented Oct 30, 2016

@jedwards1211 seems like a great idea to document this better, I'll update this thread with some thorough information about how coverage is collected when I have a few more cycles this week.

@istanbuljs istanbuljs deleted a comment from stale bot Feb 8, 2019
@JaKXz
Copy link
Member

JaKXz commented Apr 9, 2019

I'm going to move this issue to our website repo for now, thank you for reporting it. Please feel free to make a PR, anyone who is able!

@istanbuljs istanbuljs deleted a comment from stale bot Apr 9, 2019
@JaKXz JaKXz transferred this issue from istanbuljs/nyc Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants