Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect symlink loops #5

Closed
israel-lugo opened this issue Sep 9, 2017 · 1 comment
Closed

Detect symlink loops #5

israel-lugo opened this issue Sep 9, 2017 · 1 comment

Comments

@israel-lugo
Copy link
Owner

Now that we have the --follow-dirlinks option (see #4), we need a way to detect symlink loops. If there is a symlink pointing to ., or to a parent directory, we will go in a loop.

Fortunately, os.walk() seems to stop after several levels of recursion. But still, it's probably undefined behavior.

See what commands like find or rsync do.

@israel-lugo israel-lugo added this to the capidup-cli-1.1 milestone Sep 9, 2017
@israel-lugo
Copy link
Owner Author

This must actually be fixed in the underlying capidup library. See israel-lugo/capidup#17. We still need to devise some way to report to the user when a loop has been detected; that is a UI concern, appropriate for capidup-cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant