Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ux: add configuration toggle for delegated routing #288

Open
lidel opened this issue Jun 10, 2024 · 5 comments · May be fixed by #403
Open

ux: add configuration toggle for delegated routing #288

lidel opened this issue Jun 10, 2024 · 5 comments · May be fixed by #403
Labels
effort/hours Estimated to take one or several hours enhancement New feature or request need/analysis Needs further analysis before proceeding P3 Low: Not priority right now

Comments

@lidel
Copy link
Member

lidel commented Jun 10, 2024

IPFS Camp UX improvement suggestion based on discussions with @aschmahmann

Current state

  • service-worker-gateway sends a lot of requests to https://delegated-routing.dev but (afaik) we don't have direct retrieval yet, so there is no benefit from it

Proposed UX fix

  • Empty list of deleegated routing endpoints is bad UX, as user needs to know URL of endpoint to enable it
  • Let's add a toggle that enables/disables use of addresses defined in the routing configuration field
    • It should be disabled by default, until we have direct retrieval working
@lidel lidel added this to the IPFS Camp milestone Jun 10, 2024
@aschmahmann
Copy link
Contributor

aschmahmann commented Jun 10, 2024

@lidel I don't know if that fix is quite enough. If the delegated routing endpoints are being used for IPNS resolution (as opposed to using the trustless gateway endpoints) then we still need them around even if not doing direct retrievals.

We could at the Helia level not turn on the content or peer routing systems though (or potentially use the trustless gateways for IPNS fetch).

@lidel
Copy link
Member Author

lidel commented Jun 10, 2024

Yes, the idea here is to have "quality of life" toggle that disables all delegated routing, and only relies on trustless gateways.

You can still do IPNS via trustless gateways alone, but if verified-fetch does not leverage it yet, we can simply error on IPNS errors, informing user they need to enable delegated routing.

@2color
Copy link
Member

2color commented Jun 13, 2024

This seems like a duplicate of #267.

@lidel I don't know if that fix is quite enough. If the delegated routing endpoints are being used for IPNS resolution (as opposed to using the trustless gateway endpoints) then we still need them around even if not doing direct retrievals.

That's right. Currently, Helia is built in a way that accepts 3 kinds of routers (libp2p, delegatedHTTPRouting, and httpGatewayRouting) and by default includes both delegatedHTTPRouting, and httpGatewayRouting. The problem is that if we remove the delegatedHTTPRouting, there's no way for Helia to Resolve IPNS names.

I've opened ipfs/helia#558 to address this gap in Helia.

@lidel
Copy link
Member Author

lidel commented Jun 28, 2024

Descoping from Camp milestone due to impact on DNSLink (see #303 (review)).

@SgtPooki SgtPooki linked a pull request Oct 24, 2024 that will close this issue
3 tasks
@SgtPooki
Copy link
Member

SgtPooki commented Nov 4, 2024

Do we still want to do this? I think the only action item here would be to disable delegated routing if direct retrieval is not enabled and trustless gateways are enabled.

@SgtPooki SgtPooki added need/analysis Needs further analysis before proceeding enhancement New feature or request effort/hours Estimated to take one or several hours labels Nov 4, 2024
@lidel lidel removed this from the Prod: additional features milestone Dec 5, 2024
@SgtPooki SgtPooki added the P3 Low: Not priority right now label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours enhancement New feature or request need/analysis Needs further analysis before proceeding P3 Low: Not priority right now
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants