Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage in aegir + node hangs on CI and Local Dev #1206

Open
laurentsenta opened this issue Mar 7, 2023 · 4 comments
Open

Coverage in aegir + node hangs on CI and Local Dev #1206

laurentsenta opened this issue Mar 7, 2023 · 4 comments
Assignees
@laurentsenta
Labels
team/ipdx

Comments

@laurentsenta
Copy link

laurentsenta commented Mar 7, 2023 •
edited
Loading

Describe the bug

We had to disable code coverage in node 18, which pushed the burden of checking code coverage onto maintainers and PR reviewers.

@achingbrain has prepared a PR to enable it back, but it's still blocking:
#1195

Examples:
https://github.com/ipfs/aegir/actions/runs/4225847659/jobs/7338650113

@BigLep shared details on why we need to solve this in https://filecoinproject.slack.com/archives/C03KLC57LKB/p1678122004165499

Options:
@laurentsenta
Copy link
Author

Issue was created in bcoe/c8#454

There is a nodejs related issue discussed in bcoe/c8#432, which leads to nodejs/node#45013 and nodejs/node#45055.

Naively, I tried to run the test on many different version, hoping I would find a clear "v18 is broken" or something.
But, if you exclude the "missing fetch function" on older nodejs versions, it seems that every version hangs, except the node v19 on windows:
https://github.com/laurentsenta/aegir/actions/runs/4353486483/jobs/7607591085

@laurentsenta laurentsenta self-assigned this Mar 7, 2023
@RonaldZielaznicki
Copy link

According to this comment (bcoe/c8#432 (comment)), folks are able to fix the issue by moving to node v20.

@achingbrain
Copy link
Member

achingbrain commented Jun 10, 2023 •
edited
Loading

I've updated the PR that re-enables coverage to only run coverage on node 20 but it still hangs so I think that comment is a red herring.

Edit: Actually looking at that issue they're reporting a segfault which is not the problem we are seeing. The problem we see is detailed above - the process hangs after the test run finishes, it doesn't crash.

@achingbrain
Copy link
Member

Possibly related: nodejs/node#49344

@achingbrain achingbrain changed the title Coverage in aegir + node v18 hangs on CI and Local Dev Coverage in aegir + node hangs on CI and Local Dev Nov 1, 2023
achingbrain added a commit that referenced this issue Nov 1, 2023
@achingbrain
fix: if a test run looks like it's hung during coverage, kill it
dc120e1 
Watch for test output that looks like the end of a successful test
run - if collecting coverage takes too long, kill the process but
do not cause the test run to fail.

Temporary workaround for #1206
@achingbrain achingbrain mentioned this issue Nov 1, 2023
Merged
achingbrain added a commit that referenced this issue Nov 1, 2023
@achingbrain
fix: if a test run looks like it's hung during coverage, kill it
8f1c940 
Watch for test output that looks like the end of a successful test
run - if collecting coverage takes too long, kill the process but
do not cause the test run to fail.

Temporary workaround for #1206
achingbrain added a commit that referenced this issue Nov 2, 2023
@achingbrain
fix: if a test run looks like it's hung during coverage, kill it (#1406)
8b526fc 
Watch for test output that looks like the end of a successful test
run - if collecting coverage takes too long, kill the process but
do not cause the test run to fail.

Temporary workaround for #1206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurentsenta laurentsenta

Labels
team/ipdx
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@achingbrain @laurentsenta @RonaldZielaznicki