Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more meaningful progress bar #38

Open
cisert opened this issue Aug 25, 2023 · 1 comment
Open

Use more meaningful progress bar #38

cisert opened this issue Aug 25, 2023 · 1 comment

Comments

@cisert
Copy link

cisert commented Aug 25, 2023

Fantastic tool, thank you! :)
Just a small suggestion for improvement: When running a query, a progress bar is shown for each download of the resulting files, each taking <1 s (making the progress bar somewhat useless). It would be more meaningful to have the progress bar indicate the overall progress (downloaded structures/total structures to be parsed).

@ioChris
Copy link
Owner

ioChris commented Aug 30, 2023

Thank you for the feedback!
The progress bar as it is reflects the processing of individual chains - not "download" per se, but alignment and other operations performed on each chain that result in its apo/holo classification. It is indeed partial as it does not include initial processes, i.e., verifying the query structure or finding which chains to process in the first place.

It would require some code shuffling to include previous processing into the progress bar but it is a good suggestion worth implementing. What do you think @rdk ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants