fix(worker): only apply processor cancel logic if cancel event is for current item #7416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… current queue item
maryhipp
requested review from
blessedcoolant,
psychedelicious,
brandonrising and
hipsterusername
as code owners
github-actions
bot
added
python
psychedelicious
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in the session processor where a cancel event for any queue item was triggering the processor to cancel the current queue item.
Related Issues / Discussions
Closes #7414
QA Instructions
Queue up a batch of generations and cancel some at the end. The currently processing queue item should still finish and have expected output appear.
Merge Plan
Should be reviewed by @psychedelicious before merge
Checklist
What's Newcopy (if doing a release after this PR)