Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomClaims "stripeRole" is removed on overdue subscriptions. #588

Open
ClassyD opened this issue Dec 16, 2023 · 0 comments
Open

CustomClaims "stripeRole" is removed on overdue subscriptions. #588

ClassyD opened this issue Dec 16, 2023 · 0 comments
Labels

Comments

@ClassyD
Copy link

ClassyD commented Dec 16, 2023

Bug report

  • Extension name: [e.g. firestore-stripe-payments]

Describe the bug

I'm not sure if this a bug or a feature 馃槃
So when a user's subscription payment is 'overdue' i.e (payment failed, card declined on subscription update) it seems that the stripeRole claims is removed.

I think its because of this line

if (['trialing', 'active'].includes(subscription.status)) {

it should probably also include 'overdue' 馃 or something along that line

To Reproduce

  1. Subscribe to a product
  2. update the payment method so that the payment fails due to insufficient funds
  3. the subscription status is then set to 'Overdue' by stripe
  4. Then the stripeRole is removed

Expected behavior

I expect that that the stripeRole is only removed once the subscription status is 'Canceled '
Which means during the 'overdue' period the user has a grace period until the issue is resolved with the payments or the subscription is cancelled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants