Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support the max height option for inline adaptive banners #541

Closed
1 task
markwilcox opened this issue Feb 2, 2024 · 2 comments · May be fixed by #663
Closed
1 task

[Feature Request] Support the max height option for inline adaptive banners #541

markwilcox opened this issue Feb 2, 2024 · 2 comments · May be fixed by #663
Labels
help wanted Extra attention is needed stale

Comments

@markwilcox
Copy link

What happened?

Inline adaptive banners are designed for scrolling content. If that content is a feed with fairly consistent cell sizes then the larger sizes of banner available can be terrible for the UX.

The native SDKs support a method to get an inline adaptive banner with a width and max height (rather than just a width) but we can't access this through the React Native SDK.

The standard banners don't work so well in a feed in practice because they always take up their fixed height while loading and the API doesn't provide any feedback on loading unless it fails.

It would be ideal if the BannerAd component could take an optional max height that if supplied for an inline adaptive banner would cause the alternative native SDK method to be used and restrict the height. 🙏

Platforms

Android and iOS

React Native Info

All recent versions

Are your using Typescript?

  • My project is using Typescript

package.json

n/a

app.json

n/a

ios/Podfile

No response

android/build.gradle

No response

android/app/build.gradle

No response

android/settings.gradle

No response

AndroidManifest.xml

No response

@markwilcox markwilcox added the help wanted Extra attention is needed label Feb 2, 2024
@dylancom
Copy link
Collaborator

dylancom commented Feb 6, 2024

As this package is a community effort, it would be great if you can submit a Pull Request to make this happen!

Copy link

github-actions bot commented Mar 5, 2024

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 5, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed stale
Projects
None yet
2 participants