New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Sign in with Apple OAuth Provider - add ability to set full name #7603
Comments
This is an essential feature since Apple rejects apps that don't set the user name based on what is provided by the Apple authentication process. |
Hi there! In an open source contexts, essential features that are important to you may be implemented at any time via a pull request - I review them all and merge everything that looks good as fast as possible with quick releases Otherwise, you'll have to be patient and hope some kind fellow developer implements the thing you need, but that will not be in your control |
Hello 👋, to help manage issues we automatically close stale issues. This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?
Thank you for your contributions. |
This would be a great addition to the library. |
With release 10.7.0 of firebase-ios-sdk the auth module gained the ability to set the full name for sign in with apple: https://firebase.google.com/support/release-notes/ios#authentication_7
The OAuth provider likely needs an extension to accept the new parameter (hopefully optional...at least at the javascript layer here) and then call the new API signature in the underlying firebase-ios-sdk
Likely location to add new parameter for the full name in the Apple OAuth credential creation:
react-native-firebase/packages/auth/lib/providers/AppleAuthProvider.js
Lines 29 to 34 in ff32fd3
Likely location to swap out the current more generic OAuthProvider call for the apple-specific one mentioned here firebase/firebase-ios-sdk#4393 (comment):
react-native-firebase/packages/auth/ios/RNFBAuth/RNFBAuthModule.m
Lines 1349 to 1351 in ff32fd3
PRs welcome! Confirmed that it is tested and working locally critical...
As mentioned in #4046
The text was updated successfully, but these errors were encountered: