Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Sign in with Apple OAuth Provider - add ability to set full name #7603

Open
mikehardy opened this issue Jan 31, 2024 · 4 comments
Open
Labels
Help: Good First Issue Issues that are non-critical issues & well defined for first time contributors. Help: Needs Triage Issue needs additional investigation/triaging. Impact: Bug New bug report

Comments

@mikehardy
Copy link
Collaborator

With release 10.7.0 of firebase-ios-sdk the auth module gained the ability to set the full name for sign in with apple: https://firebase.google.com/support/release-notes/ios#authentication_7

The OAuth provider likely needs an extension to accept the new parameter (hopefully optional...at least at the javascript layer here) and then call the new API signature in the underlying firebase-ios-sdk

Likely location to add new parameter for the full name in the Apple OAuth credential creation:

static credential(token, secret) {
return {
token,
secret,
providerId,
};

Likely location to swap out the current more generic OAuthProvider call for the apple-specific one mentioned here firebase/firebase-ios-sdk#4393 (comment):

credential = [FIROAuthProvider credentialWithProviderID:provider
IDToken:authToken
rawNonce:authTokenSecret];

PRs welcome! Confirmed that it is tested and working locally critical...

As mentioned in #4046

@mikehardy mikehardy added Impact: Bug New bug report Help: Needs Triage Issue needs additional investigation/triaging. labels Jan 31, 2024
@Claeysson
Copy link

This is an essential feature since Apple rejects apps that don't set the user name based on what is provided by the Apple authentication process.

@mikehardy
Copy link
Collaborator Author

Hi there! In an open source contexts, essential features that are important to you may be implemented at any time via a pull request - I review them all and merge everything that looks good as fast as possible with quick releases

Otherwise, you'll have to be patient and hope some kind fellow developer implements the thing you need, but that will not be in your control

Copy link

github-actions bot commented Mar 4, 2024

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

@github-actions github-actions bot added the Type: Stale Issue has become stale - automatically added by Stale bot label Mar 4, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 19, 2024
@mikehardy mikehardy added Help: Good First Issue Issues that are non-critical issues & well defined for first time contributors. and removed Type: Stale Issue has become stale - automatically added by Stale bot labels May 2, 2024
@mikehardy mikehardy reopened this May 2, 2024
@siquick
Copy link

siquick commented May 3, 2024

This would be a great addition to the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help: Good First Issue Issues that are non-critical issues & well defined for first time contributors. Help: Needs Triage Issue needs additional investigation/triaging. Impact: Bug New bug report
Projects
None yet
Development

No branches or pull requests

3 participants