Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: depends-on filter should be applied to include-dependencies #560

Open
1 task done
ookami-kb opened this issue Aug 11, 2023 · 1 comment
Open
1 task done
Labels
feature request Needs: Triage The issue needs triaging

Comments

@ookami-kb
Copy link

ookami-kb commented Aug 11, 2023

Is there an existing feature request for this?

  • I have searched the existing issues.

Command

No response

Description

It would be useful to have some way of specifying the order of filtering, e.g. that depends-on filtering should be applied to packages after include-dependencies is processed.

Currently, if I run something like this:

melos exec --concurrency=1 --fail-fast --scope="$(PACKAGE)" --include-dependencies --order-dependents --depends-on="build_runner" -- "make build"

It will exec command either on dependency of the scoped package or if the scoped package depends on build_runner.

Reasoning

We use depends-on to apply the command only to the subset of packages that depend on build_runner to generate the code, and it should be generated for all the dependencies as well, but only those that depend on build_runner.

Additional context and comments

No response

@ookami-kb ookami-kb added feature request Needs: Triage The issue needs triaging labels Aug 11, 2023
@spydon
Copy link
Collaborator

spydon commented Aug 13, 2024

Just linking this in here since it is related: #702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Needs: Triage The issue needs triaging
Projects
None yet
Development

No branches or pull requests

2 participants