Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a logo to docs causes side menu to disappear #394

Open
tqwewe opened this issue Oct 8, 2024 · 3 comments
Open

Adding a logo to docs causes side menu to disappear #394

tqwewe opened this issue Oct 8, 2024 · 3 comments

Comments

@tqwewe
Copy link

tqwewe commented Oct 8, 2024

I've just added a logo to my docs page, however both in local preview and live preview, this causes the side menu to disappear completely, as well as the page title and page image.

A url where this is broken can be seen here: https://docs.page/tqwewe/kameo~docs-faq
Simply removing the "logo": "..." line from the docs.json file brings back the side menu.
(The fact the logo link is broken in the example url is unrelated to this issue).

Screenshot 2024-10-09 at 1 28 20 am
@tqwewe
Copy link
Author

tqwewe commented Oct 8, 2024

Oops, I've realised this is due to me specifying "logo": "url-here", instead of "logo": { "light: "url-here", "dark": "url-here" }. However there's no errors in the console or diagnostic issues shown, so this is pretty confusing, especially since the logo does in fact show correctly.

@Ehesp
Copy link
Member

Ehesp commented Oct 8, 2024

Oh this is weird! I'll check it out why that happens.

As for invalid config, I'm not sure on the best place to surface issues to the user(?)

@tqwewe
Copy link
Author

tqwewe commented Oct 8, 2024

Personally I would expect it to come up as one of the diagnostic errors when doing a live preview. The same kind of errors for when you have a link to a page that doesn't exist. But not sure how trivial this is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants