Fix #21: Pass localId to user update request #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hello! Sorry for the delay Could you add a test for this? |
|
Hey @rrousselGit, no problem! I'll quickly add a test for this one. |
|
Hi again @rrousselGit, can you please check if the added test case is enough for this? Regards :) |
blaugold
added a commit
to lotum/dart_firebase_admin
that referenced
this pull request
Mar 19, 2024
PR with fix in upstream: invertase#25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21.
This might a be missed implementation, when sending
GoogleCloudIdentitytoolkitV1SetAccountInfoRequestlocalId (which is basically the UID) was not set to the passed UID. Hence caused #21.Tested locally, please let me know if we are looking to add tests somehow for this.
Cheers!