Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not able to pass parser options #12

Open
orneryd opened this issue Mar 22, 2017 · 6 comments · May be fixed by #41
Open

not able to pass parser options #12

orneryd opened this issue Mar 22, 2017 · 6 comments · May be fixed by #41
Assignees
Milestone

Comments

@orneryd
Copy link

orneryd commented Mar 22, 2017

the options are hardcoded and cannot be overriden. You should retain key camelcasing by default.

@foobar98
Copy link

@nsinghal12 I don't see the options being hardcoded anywhere. Not valid anymore I guess.

@nsinghal12
Copy link
Collaborator

@foobar98 Parser options are hardcoded at line 10. This is a valid issue.

@foobar98
Copy link

Okay, I thought he meant the main parse options. What should be the ideal solution in this case then - clients can pass xmljsOptions as part of the parse options? And if nothing is provided we default to our hardcoded values?

@nsinghal12
Copy link
Collaborator

@foobar98 Yes, we should add these options to the first argument in parse call and fallback to defaults when not provided.

@nsinghal12
Copy link
Collaborator

This issue is available to be picked up for hacktoberfest. Please comment here if anyone wants to pick this one.

@nsinghal12 nsinghal12 added this to the 2.0.0 milestone Oct 28, 2022
@foobar98
Copy link

Willing to take this if nobody else is.

@foobar98 foobar98 linked a pull request Nov 5, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants