Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should be a runtime warning to prevent from using legacy value when legacy is set to false #1347

Open
kazupon opened this issue Mar 5, 2023 · 0 comments
Open

should be a runtime warning to prevent from using legacy value when legacy is set to false #1347

kazupon opened this issue Mar 5, 2023 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing Status: PR Welcome Welcome to Pull Request Type: Improvement Includes backwards-compatible fixes

Comments

@kazupon
Copy link
Member

kazupon commented Mar 5, 2023 

          @kazupon Shouldn't there be a TypeScript or runtime warning to prevent people from using legacy value when `legacy` is set to `false` and vice-versa ?

Originally posted by @mrleblanc101 in #1338 (comment)
@kazupon kazupon added good first issue Good for newcomers help wanted Extra attention is needed Status: PR Welcome Welcome to Pull Request Type: Improvement Includes backwards-compatible fixes 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Mar 5, 2023 — with Volta.net
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing Status: PR Welcome Welcome to Pull Request Type: Improvement Includes backwards-compatible fixes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kazupon