Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annotate: not process SFC parse and annotate at the same time #37

Open
3 tasks done
kazupon opened this issue Oct 20, 2021 · 0 comments
Open
3 tasks done

annotate: not process SFC parse and annotate at the same time #37

kazupon opened this issue Oct 20, 2021 · 0 comments
Labels
Status: PR Welcome Welcome to Pull Request Status: Proposal Request for comments Type: Improvement Includes backwards-compatible fixes

Comments

@kazupon
Copy link
Member

kazupon commented Oct 20, 2021

Clear and concise description of the problem

In the current implementation, SFC parse and annotate will be processed for each file.
Therefore, if an SFC parse error occurs in the middle of the process, the files processed up to that point will still be modified by annotating.

If you are using git, you can use git checkout to undo the changes, but the recovery process is tedious annotating

Suggested solution

Instead of doing SFC parse and annoate at the same time, you should do all SFC parse and then annoate.

Alternative

We can provide —verify options.
it checks SFC files whether that is syntax correctly.

Additional context

No response

Validations

@kazupon kazupon added Status: Proposal Request for comments Status: PR Welcome Welcome to Pull Request Type: Improvement Includes backwards-compatible fixes labels Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: PR Welcome Welcome to Pull Request Status: Proposal Request for comments Type: Improvement Includes backwards-compatible fixes
Projects
None yet
Development

No branches or pull requests

1 participant