Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small change and a question #127

Closed
isc-solon opened this issue Sep 3, 2019 · 5 comments
Closed

Small change and a question #127

isc-solon opened this issue Sep 3, 2019 · 5 comments

Comments

@isc-solon
Copy link

Small change: please change COS to ObjectScript in the help for /sql (and anywhere else).

Question: why is there a space between the namespace and the >?
USER > instead of USER>

@nikitaeverywhere
Copy link
Member

nikitaeverywhere commented Sep 3, 2019

Hello @joelsolon! Glad to hear from you!

Small change: please change COS to ObjectScript in the help for /sql (and anywhere else).

Noted. Will fix it within a couple of days (possibly today).

Question: why is there a space between the namespace and the >?

This is just an aesthetic question. From the very beginning of development, I thought that if there is a space after >, why not to add a space beforehand as well. As well as, for example, some terminal emulators replace the default prompt symbol to something else at all (like λ). Are there any reasons not to add this space?

@isc-solon
Copy link
Author

Your comment above reminded me that my real question is: "why is there a space after the >?" Because a space after the > in InterSystems Terminal has a special meaning!

If training or certification materials show a screenshot from WebTerminal that looks like this:
USER > set x = 4
a reader using InterSystems Terminal might think that they should type a space before the set statement, and they won't understand why their statement didn't actually set x.
It looks like it's not a problem the other way, because WebTerminal ignores any leading spaces before a statement. And it looks like WebTerminal doesn't support the ancient form of writing a routine this way, using ZI, ZL, ZS commands.

@nikitaeverywhere
Copy link
Member

nikitaeverywhere commented Sep 3, 2019

Interesting.

You right, in WebTerminal, the space character goes before and after > symbol. But, on the other hand, if we change it now, WebTerminal users will be confused. I wouldn't call it even an issue to be honest. Even though spaces do matter in ObjectScript 🤗

Regarding the ancient form of writing routines, yep, that's true, until we find something better than using xecute under the hood in the core of WebTerminal. It might not support ZI, ZL, ZS commands now, as well as some other core features (like $ZA and $ZB variables).

@isc-solon
Copy link
Author

isc-solon commented Sep 3, 2019

I agree; it's not an issue. It was a question added as part of an issue that almost became an issue on its own ;-). I wouldn't bother changing it now, only to support ZI, ZL, ZS. Should I go ahead and close?

@nikitaeverywhere
Copy link
Member

@joelsolon, fixed in WebTerminal v4.9.0 along with adding call support in /sql. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants