-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a Way to Remove Callbacks in WebTerminal API #108
Comments
Why do you need to stop them from triggering? |
@wcjphoenix, one of the examples, I thought that when the user completes a task in your project, you may want to stop callback from happening. This is all about providing the complete pub-sub pattern. In JavaScript, for example, everywhere where you have |
Actually I made a little design mistake, I should have named the functions of |
I think it would be good to wait until the next update, but thanks for the explanation about the reasoning behind a remove function. |
Done by af4c564. I also updated WebTerminal global versions and added docs. If you have any further questions or suggestions, please tell me! Thanks! |
Terminal API functions onOutput, onUserInput and execute (#107) are invoking callbacks, but there may be a need to stop triggering them at some point.
Provide some API to remove callbacks.
Info @wcjphoenix
The text was updated successfully, but these errors were encountered: