Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-adjust session amount if outgoing payment fails with non-positive amount #461

Open
raducristianpopa opened this issue Jul 30, 2024 · 0 comments
Open

Re-adjust session amount if outgoing payment fails with non-positive amount #461

raducristianpopa opened this issue Jul 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@raducristianpopa
Copy link
Member

raducristianpopa commented Jul 30, 2024 •
edited by sidvishnoi
Loading

Context

Adjusting session might fail in top-level calls. We should adjust again when needed.

Todos

  • In PaymentSession, handle isNonPositiveAmountError with adjusting amount for that session at given rate.
  • Also, in monetization service we should retry the probing if it fails for a specific tab.
@raducristianpopa raducristianpopa added the enhancement New feature or request label Jul 30, 2024
@sidvishnoi sidvishnoi added this to the WM Backlog milestone Jul 30, 2024
@raducristianpopa raducristianpopa removed this from the WM Backlog milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Web Monetization Extension
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sidvishnoi @raducristianpopa