-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure wallet addresses are case insensitive #2815
Comments
Is there anyone working on this yet? I'd like to try it:) |
Go for it :) |
Hi, I looked at the code and then I thought it would be enough modifying the wallet addres url to lower case before it got registered in the database. When i tested the wallet address creation in Rafiki Admin it stored the wallet address url in lower case successfully. By this time i left my code letting both the storage and the getWalletAddressUrl using the 'toLowerCase' function. This seems to patch the case-sensitiveness in the storing and in the looking. I don't know if the modified storage would affect any other scenarios. What would your feedback be? |
Even if you had upper case characters in the URL, correct?
What exactly did you end up trying? So I can understand correctly |
I made the middleware modifications because when i did some tests rafiki looked for the wallet address as it was firstly written it looked for it using the url with the upper case, when they're only stored in lower case |
@s100tist feel free to open a draft PR such that we can see what you did 🙂 |
Context
Because wallet addresses (and payment pointers) are in fact URLs, they should be case INsensitive. Currently, we are storing them in the DB simply as unique
string
without doing any cleanup beforehand, meaning, they are technically case-sensitive now.Todos
backend
are case-insensitiveThe text was updated successfully, but these errors were encountered: