Weekly Sync - 12 September 2023

[github-actions[bot]]

Please add agenda items below and give your weekly update in a comment. Thank you!

Agenda

• @sabineschaller: Does anyone need help to finish milestone apha.3 issues by end of this week?
• @sabineschaller: Does anyone need a Rafiki primer before meeting in Cluj?
  • Yes
• @sabineschaller: OP Catchup discussion update
  • https://docs.google.com/document/d/1b3caT7lWAaTA-rZMI3YTDBgInGWVa7JtMuO17vG84kg/edit?usp=sharing
• @AlexLakatos or @huijing: update on graphql plugin?
• @mkurapov: simplify admin API
  • in agreement to simplifying, will add some issues (not to be worked on right away)
• @BlairCurrey : local test coverage progress
  • separate command to generate coverage report ✅

[mkurapov]

@raducristianpopa works nice :)

[beniaminmunteanu]

Mostly went through open PR's
Found some broken url's in rafiki docs and fixed them to properly point to their rafiki.dev pages
Had discussions about incoming payment completed.
Changed testnet validations and added empty endpoint at the moment for the PaymentPointerNotFound Webhook that rafiki now sends. -> Need to look into how to properly handle it though
Improved logging ->
Got an ideea from the metrics section of this book (although i think this is the compressed version, can't find the actual full version online, and it seems to be missing part of what I went through on the subject on the paperback version)
And looked into how to implement it for observability of transactions inside testnet -> basically want to aggregate events and go for a final trace of the whole process instead of logging at each step

[Tymmmy]

Worked on withdraw money issues, websocket client part, organization stuff, and currency exchange fixes

[raducristianpopa]

Rafiki

• Feedback for chore: docker builds optimizations #1795
• Upgrade pnpm to v8 (👆)
• PR for http-signature-utils library to pin httpbis-digest-version so it can be fetched from the NPM registry instead of GH chore(deps): pin httpbis-digest-headers version open-payments#277

Testnet

• Working on Checkout flow testnet#677
• Merged feat(commerce/backend): add pre-interaction checkout flow testnet#723
• Checkout view PR feat(commerce/frontend): add checkout view testnet#731

Will work on:

• Continue with Checkout flow testnet#677 - Post-interaction flow

[sabineschaller]

I approved your docker build optimization PR but it has merge conflicts.

[raducristianpopa]

Thank you! I'll resolve the merge conflicts today.

[Fsalker]

addressed most of the change requests on my pull request (eliminating optional chaining, adequately renaming a getter, declaring a method in an interface, validating that a user is requesting an exchange quote for their accounts only, debating a couple of change requests and addressing my own change request which derived from one of these discussions, extracted asset validation in a separate method). Still got a very few change requests to address (fixing a circular dependency and extracting some common logic elsewhere)

[sabineschaller]

Update:

• I have an open PR for the liquidity webhooks:
  • feat: liquidity webhooks #1782
• PR reviews to reduce the number of open PRs
• working on changes to the OP spec
• preping Rafiki work week in Cluj

[BlairCurrey]

• opened PR to add fee calculation to quote create and started addressing feedback
• Investigated local test coverage options

[njlie]

• Added setFee call to Mock ASE seed script; will open PR for it today
  • Thanks for the assist @raducristianpopa
• Updated branch for feat(auth): add interaction model #1797 to address PR comments
• Will take a look at some backlog items

[JoblersTune]

• Completed feat: fetching retrieves non-revoked keys for a payment pointer #1837
• Started Add fees to Admin UI #1834

[dragosp1011]

• merged error logger improvements on testnet backend
• worked of improving error message on 1$ payment issue
• worked on withdrawing issues with different currencies and I'll need to recheck the list to see if there are more issues that should be solved

[mkurapov]

Auto-peering work:

• feat: DuplicatePeer error #1848
• feat: accept peering request #1849
• feat: createOrUpdatePeerByUrl mutation #1857

With one more to follow after

[rico191013]

• worked on socket backend parts
• some research about bug handling in some special cases