Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove API steps that doesn't use aliases #7

Open
noggan opened this issue Jan 3, 2017 · 1 comment
Open

Remove API steps that doesn't use aliases #7

noggan opened this issue Jan 3, 2017 · 1 comment

Comments

@noggan
Copy link
Contributor

noggan commented Jan 3, 2017

Since aliases uses the primary key of the entity we could remove a bunch of step definitions and force the usage of aliases instead.

Meaning steps that previously looked like:
I add a new car to shop with id 1
Should now be written as:
I add a new car to shop with alias s

Advantages:

  • Would reduce the code size of the ApiContext with like 30-40%
  • Standardize the way we write scenarios
  • Simplify the framework (for beginners)
@Hotas2k
Copy link
Contributor

Hotas2k commented Jan 3, 2017

This is almost equally to what we merged today, see https://github.com/interactive-solutions/zf-behat/releases/tag/1.0.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants