Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extension code from core header files to prevent core bloating and improve compilation times #13774

Open
lbushi25 opened this issue May 13, 2024 · 1 comment
Assignees
Labels
confirmed enhancement New feature or request

Comments

@lbushi25
Copy link
Contributor

Is your feature request related to a problem? Please describe

This PR implements the ext_oneapi_forward_progress extension: #13389.
This issue concerns the changes made by this PR to the handler.hpp file. This is a core header file and its ideal to keep it as lightweight as possible for faster compilation times. As a general rule of thumb, by blindly adding extension code to these kind of core headers, the codebase will be bloated and compilation times will suffer with each new extension.

Describe the solution you would like

Refactor the changes made by this PR with the goal of keeping as little code as possible in handler.hpp.

Describe alternatives you have considered

No response

Additional context

No response

@lbushi25
Copy link
Contributor Author

@aelovikov-intel FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant