You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The 'project' name is not URL encoded, so whenever it has characters that need to be URL encoded, gergich fails.
For example if the GERRIT_PROJECT env variable is something like 'some/project', then it is put into the URL string(for the gerrit API calls) as is, but it should be encoded to be 'some%2Fproject'.
since i dont have the permissions to push a pull request, im writing a proposal here:
change lib/gergich.rb:55 to "#{ERB::Util.url_encode info[:project]}~#{ERB::Util.url_encode info[:branch]}~#{info[:change_id]}"
Adapt test in spec/gergich_spec.rb:64
The text was updated successfully, but these errors were encountered:
The 'project' name is not URL encoded, so whenever it has characters that need to be URL encoded, gergich fails.
For example if the GERRIT_PROJECT env variable is something like
'some/project'
, then it is put into the URL string(for the gerrit API calls) as is, but it should be encoded to be'some%2Fproject'.
since i dont have the permissions to push a pull request, im writing a proposal here:
"#{ERB::Util.url_encode info[:project]}~#{ERB::Util.url_encode info[:branch]}~#{info[:change_id]}"
The text was updated successfully, but these errors were encountered: