Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Torch 2.4 (required for Intel Gaudi 1.18.0) #293

Open
Tracked by #2484
ktam3 opened this issue Oct 22, 2024 · 1 comment · May be fixed by #268
Open
Tracked by #2484

Support Torch 2.4 (required for Intel Gaudi 1.18.0) #293

ktam3 opened this issue Oct 22, 2024 · 1 comment · May be fixed by #268
Assignees

Comments

@ktam3
Copy link

ktam3 commented Oct 22, 2024

Is your feature request related to a problem? Please describe.
InstructLab 0.19.3 and its dependencies limit PyTorch to <2.4.0. Intel Gaudi software 1.18.0 just came out. It comes with a custom build of Torch 2.4.0. We need to use the new version for performance improvements and better Gaudi 3 support.

Describe the solution you'd like
Please lift the restrictions to either torch>=2.3.0,<2.5.0 or torch>=2.4.0,<2.5.0.

Additional context
I'm aware that it's not a trivial change. IIRC some instructlab subpackages have a upper version limit as well. Several 3rd party packages like vLLM and flash-attn may need to be updated, too. It might be easier to start with torch>=2.3.0,<2.5.0 everywhere, then set torch>=2.4.0,<2.5.0 in instructlab CLI last.

@ktam3 ktam3 linked a pull request Oct 22, 2024 that will close this issue
@nathan-weinberg nathan-weinberg linked a pull request Oct 23, 2024 that will close this issue
@ktam3
Copy link
Author

ktam3 commented Nov 12, 2024

James to create a new PR for this for bumping to Torch 2.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants