Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest.sh #86

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

gabriel-v
Copy link

@gabriel-v gabriel-v commented Sep 7, 2023

closes #85

Right now, I have a messy docker run script.

Maybe this would be cleaner if I added a new service in the compose file, built from ./Dockerfile, start it with sleep infinity as the command, and docker compose exec into it instead of running a new container every time. We could then use docker-compose for the networking between containers, use depends_on and healthchecks to wait for the db to be up (instead of until psql 'select 1;' do sleep 1; done, and so on.

Problems with current implementation:

@gabriel-v gabriel-v force-pushed the test-docker-one-liner branch from d6b62d8 to 719c042 Compare September 8, 2023 13:13
@gabriel-v gabriel-v force-pushed the test-docker-one-liner branch from 719c042 to 202be94 Compare September 8, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

One-liner to run pytest and lint under Docker
1 participant