-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Use GitHub Annotation output when run in PR, regular output otherwise #22
Comments
I guess we can easily achieve that by adding following to the step:
|
Yes @Chrico the problem is that for Psalm, for example, we have a Or maybe we remove that part from the default and add a separate input |
I think this is consistent with other workflows, but now that I've used these workflows for a while, I'm seeing that "GitHub Annotation" format works very well on PRs, but very badly on regular commits.
In fact, on regular commits the annotations are printed without an indication of the file/line where the error happened, making it very hard to fix the issues.
This is true for all the tools: PHPCS, Psalm, etc.
The ideal scenario would be using "GitHub Annotation" format when the current event is a PR, and standard console output in the other cases.
Originally posted by @gmazzap in #19 (comment)
The text was updated successfully, but these errors were encountered: