Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Azure Repos active comment thread #2937

Open
alikhajeh1 opened this issue Mar 11, 2024 · 0 comments
Open

Support Azure Repos active comment thread #2937

alikhajeh1 opened this issue Mar 11, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@alikhajeh1
Copy link
Member

Currently when Infracost posts a PR comment to Azure Repos, it marks the comment as closed to avoid triggering blocking behaviors or cause additional work for engineers. In our experience that works better for cost comments, and from Infracost Cloud you can configure certain checks (such as tagging policies) to block PRs until they’re resolved.

A user in the community reported the following, which sounds like having an env var/flag to change this behavior could be useful:

My aim is to enable a policy in AZDO to ensure that the cost changes have been acknowledged before merging the PR. To do this any new comment needs to appear as "active" as opposed to "closed". The current workaround is to install another 3rd party tool post and additional comment after infracost has posted. AFAIK the default state for a post is active.
We have a specific requirement that the team of engineers working on a particular project take accountability for the code that they deploy to the many envs. By posting "active" comments as opposed to "closed", the senior Dev merging the code into the main branch will have to acknowledge the cost changes that come with code change. We have this policy applied to main.
image (1)
In our use case the same terraform code gets applied to each env with a seperate TFVARS. Each change made eventually gets deployed across multiple envs. Infracost highlights how each change affects DEV, INT, STA & PRD. I.e creating an new app service plan - ensuring that DEV is on a free or S1 tier where PRD could be on a S3. With the cost comment needing to be resolved, we can use this as a sign off.

@alikhajeh1 alikhajeh1 added the enhancement New feature or request label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant