Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): upgrade golang to 1.18.6 #5996

Closed
wants to merge 2 commits into from
Closed

chore(build): upgrade golang to 1.18.6 #5996

wants to merge 2 commits into from

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Aug 16, 2022

Closes #5995

This PR upgrades golang to 1.18.5

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • Any changes to etc/Dockerfile_build have been pushed to DockerHub, and the changes have been added to .circleci/config.yml

@sranka
Copy link
Contributor Author

sranka commented Aug 16, 2022

@ivankudibal this PR requires a new build image to be ready for review - https://github.com/influxdata/chronograf/blob/master/etc/README.md

@sranka sranka changed the title chore(build): upgrade golang to 1.18.5 chore(build): upgrade golang to 1.18.6 Sep 12, 2022
@jdstrand
Copy link
Contributor

@sranka - hey, curious on the status of this? (also, thanks for working on it! :) )

@sranka sranka added this to the 1.10.1 milestone Sep 29, 2022
@sranka
Copy link
Contributor Author

sranka commented Sep 29, 2022

@sranka - hey, curious on the status of this? (also, thanks for working on it! :) )

we will resume working on security fixes before the next chronograf release, it is not a priority now

@jdstrand
Copy link
Contributor

FYI, 1.18.7 has since been released.

@jdstrand jdstrand removed the request for review from ivankudibal February 27, 2023 18:15
@jdstrand
Copy link
Contributor

@jeffreyssmith2nd - 1.18.9 has since been released and is the latest 1.18 release with security fixes. Please note that 1.18 is EOL now and 1.19.6 is has all the fixes. It is fine to update to 1.19 in two different steps if that is easier (1.18.9/1.18.10 then 1.19.6). Or feel free to go straight to 1.19.6.

@sranka
Copy link
Contributor Author

sranka commented Feb 28, 2023

Closed in favor of #6026

@sranka sranka closed this Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jeffreyssmith2nd jeffreyssmith2nd

Labels
None yet
Projects
None yet
Milestone
1.10.1
Development

Successfully merging this pull request may close these issues.

Please upgrade golang to 1.18.6 for security fixes
4 participants
@sranka @jdstrand @ivankudibal @jeffreyssmith2nd