Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of jsonapi-angular package.json #940

Open
2 of 8 tasks
fvoska opened this issue Jun 13, 2022 · 1 comment
Open
2 of 8 tasks

Better handling of jsonapi-angular package.json #940

fvoska opened this issue Jun 13, 2022 · 1 comment
Assignees
Labels
angular internal An issue for internal code structure, not exposed to the outside

Comments

@fvoska
Copy link
Contributor

fvoska commented Jun 13, 2022

Relevant version

  • 0.x
  • 1.x
  • 2.x

Relevant libraries

  • utils
  • core
  • network
  • jsonapi
  • jsonapi-angular

Breaking change

No

Description

Currently, there are multiple package.json files in the repository:

We can probably simplify the whole setup by removing one of the two angular packages (probably projects/datx-jsonapi-angular/package.json) or use them differently during the build process

@fvoska fvoska added internal An issue for internal code structure, not exposed to the outside angular labels Jun 13, 2022
@fvoska fvoska self-assigned this Jun 13, 2022
@fvoska
Copy link
Contributor Author

fvoska commented Jun 24, 2022

https://github.com/infinum/datx/blob/master/packages/datx-jsonapi-angular/package.json and https://github.com/infinum/datx/blob/master/packages/datx-jsonapi-angular/projects/datx-jsonapi-angular/package.json have been updated in #966 to make the use cases for these two separate package.json files clearer. projects/datx-jsonapi-angular/package.json is used for publishing to npm and has all the required metadata for NPM, package.json is used for development.

@fvoska fvoska closed this as completed Jun 24, 2022
@fvoska fvoska reopened this Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular internal An issue for internal code structure, not exposed to the outside
Projects
None yet
Development

No branches or pull requests

1 participant