Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify prettier config #1407

Open
joshuayoes opened this issue Jan 18, 2024 · 3 comments
Open

Simplify prettier config #1407

joshuayoes opened this issue Jan 18, 2024 · 3 comments
Labels
good first issue 🎉 Something easier for newcomers! maintenance 🔧 Dependencies, refactoring, tests, and janitor work.

Comments

@joshuayoes
Copy link
Contributor

Currently, there is a lot of copy and paste in our prettier config across workspaces.

We also have a script to copy and paste a .prettierignore file into all the workspaces https://github.com/infinitered/reactotron/blob/909427ed20ec271b3f0696c0ccbb20d7be1aebd7/scripts/copy-prettier-ignore.mjs

We should simplify it by creating one config as a workspace and then consume it in all the lib workspaces.

@joshuayoes joshuayoes added maintenance 🔧 Dependencies, refactoring, tests, and janitor work. good first issue 🎉 Something easier for newcomers! labels Jan 18, 2024
@balindam
Copy link

balindam commented May 11, 2024

hey @joshuayoes,

I am thinking of picking up this issue. I wanted to discuss with you before proceeding.

are we thinking in the direction of creating a shared configuration package for prettier and then consuming that in all the lib workspaces?

@joshuayoes
Copy link
Contributor Author

@balindam yes, that was how I was imagining it, that would be great

@balindam
Copy link

@joshuayoes while solving the above issue, I found that the .prettierignore file at the root directory applies to sub-directories as well. Then why were we copying the same .prettierignore file to sub-directories in the first place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue 🎉 Something easier for newcomers! maintenance 🔧 Dependencies, refactoring, tests, and janitor work.
Projects
None yet
Development

No branches or pull requests

2 participants