-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add id
key to plugins and add to connection info
#1385
Comments
Curious, could we also rework things so we can infer this block of plugins from the ones that actually do connect? Kind of feels funny that we have to provide all of the possible ones up front (with this source coming from |
We do infer the plugins. By default, core client has all the core plugins then adds on new client features from You can see this in Ignite because we have |
Currently in
reactotron-core-client
, we keep track of what plugins are loaded:https://github.com/infinitered/reactotron/blob/master/lib/reactotron-core-client/src/reactotron-core-client.ts#L184
However, we do not have the names of the plugins that are loaded: just the features and callbacks.
When we call
.connect()
, we send information about the connection over toreactotron-app
https://github.com/infinitered/reactotron/blob/master/lib/reactotron-core-client/src/reactotron-core-client.ts#L291-L297
We should add
id
as a field to plugins with their name so thatreactotron-app
can be customized based on what plugins are configured in the client. This would unblock this issue #1345 (comment)The text was updated successfully, but these errors were encountered: