Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate reactotron-react-js and move functionality into reactotron-react-native. #1384

Open
joshuayoes opened this issue Dec 20, 2023 · 1 comment
Labels
hold my beer 🍺 This may be crazy but... maintenance 🔧 Dependencies, refactoring, tests, and janitor work.

Comments

@joshuayoes
Copy link
Contributor

joshuayoes commented Dec 20, 2023

At least internally, most uses of Reactotron for web are either Expo web or react-native-web exports of a React Native app.

In Ignite, we need to an awkward re-export of ReactotronClient to get our Reactotron config to work properly https://github.com/infinitered/ignite/blob/master/boilerplate/app/devtools/ReactotronClient.web.ts

reactotron-react-js is not a lot of code, it is:

These can be inlined into reactotron-react-native with .web.ts alternatives. This is a more familiar pattern to React Native libraries since Metro handles bundling platform extensions.

Now that we can ship source code in Reactotron and let Metro bundle it, this pattern would be easier to use.

TODO:

  • figure out how to handle platform extensions in Rollup bundle.
@joshuayoes joshuayoes added maintenance 🔧 Dependencies, refactoring, tests, and janitor work. hold my beer 🍺 This may be crazy but... labels Dec 20, 2023
@jamonholmgren
Copy link
Member

This is a great idea. All for it.

Perhaps we should call it reactotron-react.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold my beer 🍺 This may be crazy but... maintenance 🔧 Dependencies, refactoring, tests, and janitor work.
Projects
None yet
Development

No branches or pull requests

2 participants