-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directories glob patterns broken when used with --git-diff-filter #1714
Labels
Comments
Having the same issue on similar scenario. |
@aurum86 could you please provide details about your case? What is the I can't reproduce it. Mention |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We run infection only over a specific subset of the codebase which contains heavy business logic. This allows us to enforce a 100% MSI for critical code paths. We do this by using file glob patterns in the
directories
config section, eg.src/*/Core
.This was recently broken by #1697, specifically by adding the
directories
configuration togit diff
command withescapeshellarg
which results in thegit diff
command being changed to the following, which returns an empty list of changes.Is there any reason that we need
escapeshellarg
here? That's usually used to prevent untrusted data being executed, but it should only ever include data provided by the same user who is running the command right?Alternatively, maybe the
directories
config property could support regex likeexcludes
does?phpunit.xml
infection.json.dist
Output with issue
The text was updated successfully, but these errors were encountered: