Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New type of question: JupyterNotebookQuestion #690

Open
dzhuang opened this issue Mar 20, 2020 · 1 comment · May be fixed by #701
Open

New type of question: JupyterNotebookQuestion #690

dzhuang opened this issue Mar 20, 2020 · 1 comment · May be fixed by #701
Labels
discussion enhancement

Comments

@dzhuang
Copy link
Contributor

dzhuang commented Mar 20, 2020 •
edited
Loading

Or JupyterNotebookUploadQuestion?
I think it's quite easy to achieve that by subclassing UploadQuestion. Features:

  1. Allow only uploading file with extension ".ipynb"
  2. Check validaty of the file
  3. Enable preview in upload ui and grading ui
  4. Prevent dangerous (JavaScript) code in preview

Any suggestions?
@inducer
Copy link
Owner

inducer commented Mar 20, 2020

That sounds like a useful feature.

@dzhuang dzhuang linked a pull request May 20, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added JupterNotebookUploadQuestion. dzhuang/relate
2 participants
@inducer @dzhuang