Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some examples of code that could be replaced by nidmresults functions #16

Open
chrisgorgo opened this issue Jan 20, 2016 · 2 comments · Fixed by #29
Open

Some examples of code that could be replaced by nidmresults functions #16

chrisgorgo opened this issue Jan 20, 2016 · 2 comments · Fixed by #29

Comments

@chrisgorgo
Copy link
Contributor

After discussion at NIDM sprint we decided to implement easy to use functions for common NIDM Results queries. This should lower the access barrier for new developer. Those functions can live in the nidmresults package. They could immediately replace some sparql queries in NeuroVault and nidmviewer (maintained by @vsoch).

get_statmaps() https://github.com/NeuroVault/NeuroVault/blob/0ba7f42a11d703ee608317fe7f0c24fd62d48fc5/neurovault/apps/statmaps/nidm_results.py#L64
as well as https://github.com/vsoch/nidmviewer/blob/882f5201354135ff4dc6ec8739621a94341d0fef/nidmviewer/sparql.py#L43
(this could be split into more functions if that makes sense)

get_coordinates()
https://github.com/vsoch/nidmviewer/blob/882f5201354135ff4dc6ec8739621a94341d0fef/nidmviewer/sparql.py#L28

@cmaumet
Copy link
Member

cmaumet commented Jan 20, 2016

Thanks @chrisfilo! This is related to #12.

@cmaumet
Copy link
Member

cmaumet commented May 26, 2016

Reading peaks and statistic map form a NIDM-Results document is now implemented, cf. bin/reader in #29 for an example of usage. I have left #29 open so that we can adapt these functions to make them as easy as possible to use from NeuroVault. Let me know what you think!

@cmaumet cmaumet reopened this Jun 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants