Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Python 3 and QT5 #6

Open
illgenr opened this issue Nov 28, 2020 · 3 comments
Open

Update to Python 3 and QT5 #6

illgenr opened this issue Nov 28, 2020 · 3 comments

Comments

@illgenr
Copy link

illgenr commented Nov 28, 2020

I've went through and updated the program for python 3 print statements and made a few tweaks to use QTWidgets where necessary for compatibility with QT5.

Should I submit a pull request to merge the changes?

@marcusmueller
Copy link

@illgenr I did my best, doing the same. Personally: Don't ask, simply do: if @in3otd doesn't want to merge, they won't and nobody has any downside from you opening a PR :)

@nrrdzilla
Copy link

Hi all,

Thanks for the mods, bringing these files up to Python3 and QT5!

Hopefully not an utterly stupid question:
I think I applied your mods to the files correctly, but I'm getting odd errors, that might be connected to something else:

Traceback (most recent call last):
  File "spiki.py", line 251, in writeModule
    fname[0] = fname[0] + '.kicad_mod'
TypeError: 'tuple' object does not support item assignment

-when I try to output the .kicad_mod file.

Any ideas where I should be digging to get to the bottom of this?

system info:
Linux Mint 20.3 x86-64
python points to /usr/bin/python3.8

AFAIK I have all the prerequisites installed, as per the instructions, but there might be something glaringly obvious I'm missing.

@benjaminaigner
Copy link

Dear @nrrdzilla ,

I've just tried this tool the first time and had the same error. The workaround: store your output file with the .kicad_mod extension, then it works.

Of course this is no fix, but works.

@illgenr THX for the port to Python3 + QT5

@in3otd THX for this tool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants