Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a handler for requeuing jobs #227

Open
in03 opened this issue Sep 16, 2022 · 1 comment
Open

Add a handler for requeuing jobs #227

in03 opened this issue Sep 16, 2022 · 1 comment

Comments

@in03
Copy link
Owner

in03 commented Sep 16, 2022

Currently it's possible to requeue the same job when it's already encoding.
It's not likely you'll run into it unless two timelines share the same file or the same timeline is requeued while it's still processing for some reason (maybe found new files or the first attempt exited early or something).

Anyway, the current behaviour is a little weird. I believe Proxima will ask you if you want to link the existing file even though it's not finished. Of course it will fail and you'll be asked if you want to requeue it. This assumes that the file is corrupt and needs re-encoding. Not that the file may already be encoding. We can check all Proxima jobs and see if any share the same source path with ones we'd like to queue.

@in03
Copy link
Owner Author

in03 commented Oct 18, 2022

Looks like it'll be a little complicated to use Celery event snapshots.

Another method would be to watch all existing paths asynchronously in another process while running the other handlers.
If any have grown, we remove them from the media list. Adding async this late in the game might be pretty messy though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant