-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad TS types for proto3 optional fields #295
Comments
toObject() for proto3 optional fields are still generated like so by the protoc js compiler:
Note the This conforms with the google-protobuf getter APIs and getter semantics in other languages. Please do not change this behavior with toObject(). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a proto file has an optional field:
It generates this TS definitions
I think the namespace should be in this format:
I can find out if the field is in the message by using
hasOptionalField
method. But TS check is not working as expected.The text was updated successfully, but these errors were encountered: