-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ShrineS3 url needs to be configurable? #34
Comments
The gem didn't use Shrine's prefix. Fixed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In my shrine setup, the S3 urls are in the format
"s3://#{image.storage.bucket.name}/store/#{image.id}"
. I've overriddenImgproxy::UrlAdapters::ShrineS3#url
to customize this, but perhaps it would be a good idea to make this configurable?The text was updated successfully, but these errors were encountered: