Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL language causes clipped aspect ratio button #4913

Open
1 task done
low-batt opened this issue May 5, 2024 · 2 comments · May be fixed by #4914
Open
1 task done

RTL language causes clipped aspect ratio button #4913

low-batt opened this issue May 5, 2024 · 2 comments · May be fixed by #4914
Assignees
@low-batt
Labels
bug feature: preferences priority: high progress: pr ready type: localization

Comments

@low-batt
Copy link
Contributor

low-batt commented May 5, 2024 •
edited

System and IINA version:

Expected behavior:
Names of buttons are normally not clipped.

Actual behavior:
Currently IINA does not support any right to left languages. However PR #4922 enables Hebrew. If you build IINA with that pull request and set Hebrew as the language and open the quick setting panel the Default ("ברירת מחדל") button under Aspect ratio is clipped:
clipped

This problem was reported by @ShlomoCode in issue #4776. As that issue reports quite a few RTL related problems I have created this issue to focus just on this particular problem.

Steps to reproduce:

  • Pull PR feat: enable hebrew locale #4864

  • Open the IINA project in Xcode

  • Under the Product menu open the Scheme menu and select Edit Scheme…

  • Click on the Options tab

  • Scroll down to the App Language setting

  • In the pull down select Hebrew

  • Start IINA running under Xcode

  • Start playing a video

  • Press ⇧⌘V to show the video panel

  • Notice the Default ("ברירת מחדל") button is clipped

  • MPV does not have this problem.

mpv does not support localization.

How often does this happen?
Every time.
@low-batt low-batt self-assigned this May 5, 2024
low-batt added a commit that referenced this issue May 5, 2024
@low-batt
Fix RTL language causes clipped aspect ratio button, #4913
c736739 
This commit will change the constraint on the CustomAspectRatio text
field from "width == 60" to "width >= 30". This allows this field to be
compressed allowing the segmented control to expand enough to avoid
clipping the default button.
@low-batt low-batt linked a pull request May 5, 2024 that will close this issue
Open
2 tasks
@low-batt low-batt linked a pull request May 5, 2024 that will close this issue
Fix RTL language causes clipped aspect ratio button, #4913 #4914
Open
2 tasks
@low-batt
Copy link
Contributor Author

low-batt commented May 5, 2024

With the proposed fix in the PR:
fixed

@ShlomoCode
Copy link

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@low-batt low-batt

Labels
bug feature: preferences priority: high progress: pr ready type: localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix RTL language causes clipped aspect ratio button, #4913 iina/iina
2 participants
@ShlomoCode @low-batt