Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL language causes history progress indicator to reverse #4906

Open
1 task done
low-batt opened this issue May 3, 2024 · 0 comments · May be fixed by #4907
Open
1 task done

RTL language causes history progress indicator to reverse #4906

low-batt opened this issue May 3, 2024 · 0 comments · May be fixed by #4907
Assignees
@low-batt
Labels
bug feature: ui/ux priority: high progress: pr ready type: localization

Comments

@low-batt
Copy link
Contributor

low-batt commented May 3, 2024 •
edited

System and IINA version:

Expected behavior:
IINA adheres to Apple's Internationalization and Localization Guide which specifies that timeline indicators should not flip in a right-to-left language.

Actual behavior:
Currently IINA does not support any right to left languages. However PR #4922 enables Hebrew. If you build IINA with that pull request and set Hebrew as the language then the progress indicator in the history window changes direction as seen here:
history-window

This problem was reported by @ShlomoCode in issue #4776. As that issue reports quite a few RTL related problems I have created this issue to focus just on this problem.

Steps to reproduce:

  • Open the IINA project in Xcode
  • Under the Product menu open the Scheme menu and select Edit Scheme…
  • Click on the Options tab
  • Scroll down to the App Language setting
  • In the pull down select Right-to-Left Pseudolanguage near the end of the list
  • Start IINA running under Xcode
  • Click on Playback History under the File menu
  • The Playback History window appears
  • Notice in the direction of the progress indicator is flipped.

Or you can build with PR #4922 and set your language to Hebrew.

  • MPV does not have this problem.

mpv does not support localization.

How often does this happen?
Every time.
@low-batt low-batt self-assigned this May 3, 2024
low-batt added a commit that referenced this issue May 3, 2024
@low-batt
Fix RTL language causes history indicator to flip, #4906
8d69290 
This commit will add an awakeFromNib method to the
HistoryProgressCellView class that sets the progress indicator property
userInterfaceLayoutDirection to be leftToRight. This prevents the
indicator from reversing direction when a RTL language is configured.
@low-batt low-batt linked a pull request May 3, 2024 that will close this issue
Open
2 tasks
@low-batt low-batt linked a pull request May 3, 2024 that will close this issue
Fix RTL language causes history indicator to flip, #4906 #4907
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@low-batt low-batt

Labels
bug feature: ui/ux priority: high progress: pr ready type: localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix RTL language causes history indicator to flip, #4906 iina/iina
1 participant
@low-batt